Change condition and add comment

Ferlab-Ste-Justine · Oct 4, 2024 · 05a6eca · 05a6eca
1 parent 780c685
commit 05a6eca
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/java/bio/ferlab/fhir/converter/FhirAvroConverter.java b/src/main/java/bio/ferlab/fhir/converter/FhirAvroConverter.java
@@ -138,8 +138,9 @@ private static ByteBuffer bytesForString(String string) {
         return ByteBuffer.wrap(string.getBytes(StandardCharsets.UTF_8));
     }
 
+    // valueQuantity and valueCode from DeviceProperty in FHIR R4 should not be treated as value[x] fields.
     private static Boolean isRealValueXField(Base base, String fieldName) {
-        return !(base instanceof Device.DevicePropertyComponent) || (!fieldName.equals("valueQuantity") && !fieldName.equals("valueCode"));
+        return !((base instanceof Device.DevicePropertyComponent) && (fieldName.equals("valueQuantity") || fieldName.equals("valueCode")));
     }
 
     private static Optional<Property> getProperty(Base base, Schema.Field field) {