Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CQDG-887 add destroyOnClose on downloadFileManifestModal #329

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

atoulous
Copy link
Contributor

@atoulous atoulous commented Oct 1, 2024

feat: CQDG-887 add destroyOnClose on downloadFileManifestModal

  • closes #TICKET_NUMBER

Description

https://ferlab-crsj.atlassian.net/browse/CQDG-887

Acceptance Criterias

Validation

  • Code Approved
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

image

After

image

QA

Copy link

github-actions bot commented Oct 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from f72700f

@atoulous atoulous added the cypress Run cypress tests label Oct 1, 2024
@kstonge kstonge self-requested a review as a code owner October 2, 2024 15:32
@atoulous atoulous merged commit 0945ac9 into main Oct 2, 2024
6 checks passed
@atoulous atoulous deleted the feat/cqdg-887 branch October 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress Run cypress tests
Development

Successfully merging this pull request may close these issues.

3 participants