-
Notifications
You must be signed in to change notification settings - Fork 9
Cleaned code, removed smc.h, fixed typos #4
base: master
Are you sure you want to change the base?
Conversation
And moved #includes to header
I SPENT ONE FUCKING HOUR TRYING TO UNDERSTAND WHY MY CODE SEGFAULTED. Someone will be hung for that… 😡
* stringRawRepresentationForBytes:withSize:ofType:toNSString * stringRawRepresentationForBytes:withSize:ofType:inBuffer * stringRawRepresentationOfVal:inBuffer * stringRawRepresentationOfVal:toNSString Also added comments for readKey:intoVal
Bump ? |
Take a look at the 'SMCWrapper' branch in http://github.com/perfaram/xline, this is where most improvements I made here come from. |
Standardised argument for NSStrings passed ‘by reference’ Added -(BOOL) typeOfVal:(SMCVal_t)val intoString:(NSString **)str; stringRep methods now properly return true/false values (made a mistake yesterday)
Just asking, why are we passing NSStrings by reference anyways ? Couldn't we just return the NSString (which is usually easier for the programmer who uses SMCWrapper) and have the error passed by ref ? Cleaner list of options, in which
I vote for the last one. |
Was calling stringRep… instead of stringRawRep
After working a bit on other projects, I changed my mind. The current version seems good. BUT, to have more precision, we could also have a |
List :