You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently login() will cause an AttributeError if login is attempted without internet connection as post_handler will return None, meaning the check re.status_code == 200 cannot be done. This PR checks the type of re and raises requests.ConnectionError if the request to the server couldn't be made.
It also changes the status code exception raised for re.status_code != 200 from Exception to the more precise exception requests.HTTPError.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently login() will cause an AttributeError if login is attempted without internet connection as post_handler will return None, meaning the check
re.status_code == 200cannot be done. This PR checks the type ofreand raisesrequests.ConnectionErrorif the request to the server couldn't be made.It also changes the status code exception raised for
re.status_code != 200fromExceptionto the more precise exceptionrequests.HTTPError.