Skip to content

Add GitHub Actions CI workflow #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

errordeveloper
Copy link

  • Add Docker-oriented CI workflow with distinct Lint, Test & Build stages
  • Use GitHub's polyglot linter
  • Ensure tests are driven by docker-compose, which is at the centre current dev workflow
  • Enable for images to push to a registry in the future

Closes #18

@errordeveloper
Copy link
Author

errordeveloper commented Nov 26, 2020

@karenc this overlaps with what did in #17 and #25, let's discuss which way do you we want to go about this :)

When I started on this, I didn't realise you've opened #17 already...

Copy link
Contributor

@karenc karenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking again at the run-tests workflow, I think the main advantage is just the simplicity of it. Even for people who are not familiar with github actions, you can quickly tell what it is trying to do.

One of the advantages of this PR is it tries to build the docker images. It can be especially useful as our set up become more complicated in the future.

@errordeveloper
Copy link
Author

@karenc yeah, so if we stick to using same docker containers for development, testing and deployment, shouldn't have to deal with various dependencies issues in each of the environments separately. I do agree that run-tests workflow is quite simple as it stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI
2 participants