Skip to content
This repository was archived by the owner on Apr 6, 2022. It is now read-only.

Added fetch with progress #25

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

luisgurmendez
Copy link

No description provided.

@luisgurmendez
Copy link
Author

This new implementation of fetch, changes the result data response. But adds functionality to allow progress bar

@Fausto95
Copy link
Owner

Fausto95 commented Dec 1, 2018

Hi @luisgurmendez! Thanks for this PR.
I'll be testing and then merge it!

@luisgurmendez
Copy link
Author

We could maybe find a way to maintain the same response as fetch, so that the lib is compatible with earlier versions. Let me work on this a few days

@AliAdnanSohail
Copy link

Will this progress bar help in uploading file ?

@imakshath
Copy link

@Fausto95 I'm waiting for this feature..

@Fausto95
Copy link
Owner

Actually it doesn't work because you're not passing the callback function to the S3.uploadFile method!
Could you fix this?

@afolabiabass
Copy link

Hi, does this allow it possible to get progress on file upload to S3

@luisgurmendez
Copy link
Author

@Fausto95 my bad I forget to push, let me check it

@Fausto95
Copy link
Owner

Thanks buddy, it looks like your branch still not up-to-date with master which now uses TypeScript instead of normal Javascript

@luisgurmendez
Copy link
Author

@Fausto95 I've added typescript but it need to be tested I dont' have time right now :S maybe in a week or so

@afolabiabass
Copy link

Any chance this will be merged soon and released?

@tcollins590
Copy link

Any change this can be merged?

@swangy
Copy link

swangy commented Apr 4, 2020

another vote for this PR

@swangy
Copy link

swangy commented Apr 14, 2020

fyi anyone looking for this feature, i added the PR into a fork here
https://github.com/swangy/aws-s3
if anyone would like to help improve this it'd be much appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants