Allow jackson-module-jaxb-annotations to tolerate 2.2,3 in Import-Package #235
Conversation
| <version>${version.jaxb.impl}</version> | ||
| <groupId>javax.xml.bind</groupId> | ||
| <artifactId>jaxb-api</artifactId> | ||
| <version>2.2.12</version> |
There was a problem hiding this comment.
Shouldn't this instead change version.jaxb.impl property?
There was a problem hiding this comment.
No I don't think so as there is only a 2.3.3 or 2.3.2 available.
There was a problem hiding this comment.
Looks like version.jaxb.impl is used to get a JAXB impl for tests:
<!-- may also need JAXB impl for tests -->
<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<version>${version.jaxb.impl}</version>
<scope>test</scope>
</dependency>
There was a problem hiding this comment.
... but that does not seem to be needed, so I think I'll comment it out.
|
Hmmh. I am really uncomfortable with this change -- I know JAXB/Jakarta upgrade has been a Royal Mess, and I am not sure this helps in general. It seems to me that there are TWO overlapping distinct packages (as in, different Maven coordinates) that nonetheless both provide same classes: one with And in particular making change in a patch of 2.16, if breaking, would be very unfortunate. Especially as we are downgrading a dependency. Is it not possible to add local overrides on package depending on JAXB annotations module? @GedMarc WDYT? |
|
FYI we had a similar change go through in swagger-core swagger-api/swagger-core#4595 |
|
@JDUNNIN that is for OSGi dependnecy tho? Is the end results same? One other quick note: since 2.17.1 is released, this PR needs to be rebased against 2.18; will not add in a patch. |
|
@cowtowncoder yes I had originally raised PR for fix the same as this PR, but they changed it to use the OSGi method instead. The end result was the same, MANIFEST.MF updated. |
|
UGGGGH. How did this end up merging 2.18 changes to 2.16 branch.... need to untangle this now. |
|
Ok had to hard reset 2.16 branch. What I do not understand is how Github managed to merge this into 2.16 branch, despite PR clearly stating 2.18 as target... Need to re-create PR now. |
Re-apply #235 but now with 2.18 target (not sure what happened earlier)
Resolves #233
I removed the Jakarta import, from the comment
Despite groupId, this is "old" JAXB, not Jakarta (3.x is real Jakarta one)it sounds like this should be OK. The end result in the MANIFEST.MF was the same as when I just added the jaxb-api dependency above it.