Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "missing" read-only top-level workflow permissions #629

Closed
wants to merge 1 commit into from
Closed

Add "missing" read-only top-level workflow permissions #629

wants to merge 1 commit into from

Conversation

JooHyukKim
Copy link
Member

Description

Relates to security improvements made in FasterXML/jackson-core#953.

@pjfanning
Copy link
Member

These files are generated by a SBT plugin and build fails if you hand modify them

@JooHyukKim
Copy link
Member Author

JooHyukKim commented Apr 2, 2023

Oh, I see. My intention was to point out that we can configure the workflow permission here in this project.

May I ask you to modify the workflow files... when you havee time @pjfanning ? I have not heard of SBT plugin, it would take me a while to figure out what SBT plugin 🥲 We can close this PR.

Additional Note

  • I will try to find a way 👍🏻👍🏻

@pjfanning
Copy link
Member

this needs typelevel/sbt-typelevel#350

@pjfanning pjfanning closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants