Add failing test for String JsonFormat Guava Range serializer (issue #118) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
reviewed
Dec 11, 2023
| } | ||
| } | ||
|
|
||
| public void testRangeSerializationToString() throws Exception |
There was a problem hiding this comment.
Can we at least separate (by method of your choice) failing ones to passing tests?
There was a problem hiding this comment.
All of these would fail as of now. I am working on implementing the serialization for this.
cowtowncoder
changed the title
cowtowncoder
changed the title
|
Will make minor changes; add comments, fix order of assert methods ("expected" first, actual second), merge. |
cowtowncoder
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing tests to reproduce #118.