Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test method for #118 #126

Closed
wants to merge 1 commit into from
Closed

Add a test method for #118 #126

wants to merge 1 commit into from

Conversation

mukham12
Copy link
Contributor

@mukham12 mukham12 commented Dec 9, 2023

This commit introduces an initial version of the testSerializationToString method, designed to test the functionality expected by #118. The test cases are expected to fail as the underlying functionality has not been implemented. However, this provides a solid foundation to build upon and a starting point for implementing the desired functionality.

Building on @saydar31's progress, I will soon be creating a PR for the serialization of Range.

@cowtowncoder
Copy link
Member

Ok, thank you @mukham12. Failing tests need to go under src/test/java/..../failing so that our CI will stay green.

Guava module already has one test there. In this case I think you need to create separate test class for failing tests, add that there; if and when functionality is implemented, test classes can be combined.

@mukham12
Copy link
Contributor Author

Gotcha! Will close this and create a new PR with the class under the failing directory.

@mukham12 mukham12 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants