Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ion null deserialization #296

Merged
merged 3 commits into from
Sep 12, 2021
Merged

Fix ion null deserialization #296

merged 3 commits into from
Sep 12, 2021

Conversation

MartinGian
Copy link
Contributor

Fixes the IonValueDeserializer to be able to deserialize serialized null values correctly. Ion does have first class null values so a deserialized null value should never end up being a Java null value.

There is more information about this change in #295

@MartinGian MartinGian marked this pull request as ready for review September 8, 2021 12:33
@mcliedtke
Copy link
Contributor

Changes LGTM. @cowtowncoder, do you mind merging? I think 2.13 would likely make the most sense.

@cowtowncoder
Copy link
Member

Will merge (I have some concerns as to whether this will work reliably due to reliance on underlying JsonParser -- but there are tests and so perhaps it does -- and I don't have better ideas for solving it either). Unless the null value could be derived from type declaration?

But before merging, I'd suggest one addition that I mentioned, to avoid possibility of "wrong" null value getting cached.
(I forget if caching is done or not, but if it was leaving out access mode could lead to pretty weird failures).

@cowtowncoder cowtowncoder merged commit 6124d9b into FasterXML:2.13 Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants