Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

Fix issue #128 headers are not written if no rows are written #129

Merged
merged 3 commits into from
Aug 25, 2016
Merged

Fix issue #128 headers are not written if no rows are written #129

merged 3 commits into from
Aug 25, 2016

Conversation

ansell
Copy link
Contributor

@ansell ansell commented Aug 22, 2016

Fix issue #128 by writing the header during CsvGenerator.close if necessary. See issue comments for discussion so far.

@cowtowncoder
Copy link
Member

Excellent!

One process question now: if I haven't yet asked for a Contributor License Agreement:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

I'd need one before merging this. It's only needed once and covers all contributions to Jackson projects.
The usual way is to print, fill & sign, scan, email to info at fasterxml dot com.

Looking forward to merging this fix (I can backport it in 2.7.x) as well.

@ansell
Copy link
Contributor Author

ansell commented Aug 22, 2016

I haven't signed a CLA yet, will let you know when that process is complete.

@cowtowncoder
Copy link
Member

cowtowncoder commented Aug 23, 2016

@ansell No problem, thank you for the update.

Also: I gave the link to individual CLA, which most contributors use. But just in case you wanted/needed corporate CLA (sometimes case for big companies; we have 3 from "well-known" big internet companies), there's also that available as

https://github.com/FasterXML/jackson/blob/master/contributor-agreement-corporate.txt

@cowtowncoder cowtowncoder added this to the 2.7.7 milestone Aug 25, 2016
@cowtowncoder cowtowncoder merged commit 8c7213a into FasterXML:master Aug 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants