Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: order imports #4734

Open
wants to merge 1 commit into
base: 2.19
Choose a base branch
from
Open

Conversation

timo-a
Copy link
Contributor

@timo-a timo-a commented Oct 7, 2024

No description provided.

@JooHyukKim
Copy link
Member

What is the order is being based on?

@timo-a
Copy link
Contributor Author

timo-a commented Oct 7, 2024

It's based on the Jackson coding style

Comment on lines 28 to +29
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.*;
import static org.junit.jupiter.api.Assertions.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static imports should adhere to the same ordering mechanism.

Comment on lines 22 to +23
import static com.fasterxml.jackson.databind.testutil.DatabindTestUtil.*;
import static org.junit.jupiter.api.Assertions.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also. Same ordering rule applies to static import.
May I ask which tool you used to refactor this?
May I can help configuring also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants