Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more EnumNamingStrategies #4728

Merged

Conversation

lbenedetto
Copy link
Contributor

@lbenedetto lbenedetto commented Oct 2, 2024

Implements #4676

As discussed, extracted the common logic of PropertyNamingStrategies and EnumNamingStrategies to a common util class. In this case, an Enum called NamingStrategy

@cowtowncoder cowtowncoder added the 2.19 Issues planned at 2.19 or later label Oct 2, 2024
@cowtowncoder
Copy link
Member

Note to self: got CLA for this one already.

@cowtowncoder cowtowncoder added the cla-received PR already covered by CLA (optional label) label Oct 2, 2024
@@ -0,0 +1,152 @@
package com.fasterxml.jackson.databind.util;

public enum NamingStrategy {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll have to think of naming but I will want to change this a bit...

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Approved (with minor renaming)

@cowtowncoder cowtowncoder merged commit 26bdfec into FasterXML:2.19 Oct 2, 2024
8 checks passed
@cowtowncoder
Copy link
Member

Merged all the way to master/3.0!

Thank you @lbenedetto -- this is the first new feature that made it into 2.19 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.19 Issues planned at 2.19 or later cla-received PR already covered by CLA (optional label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants