StdDelegatingSerializer does not consider a Converter that may return null for a non-null input #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @plevart for both reporting the issue and contributing a fix! One thing I'd need before merging it is CLA (unless you have sent one earlier): https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the usual way is to print it, fill & sign, scan/photo, email to Thank you again! |
| } | ||
| }; | ||
|
|
||
| ObjectMapper mapper = jsonMapperBuilder() |
There was a problem hiding this comment.
Using builder since "ObjectMapper.registerModule()" removed from 3.0, builder-approach easier to merge forward.
|
Merged, will backport to 2.17(.2) next |
cowtowncoder
pushed a commit
that referenced
this pull request
Jun 13, 2024
… null for a non-null input (#4576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #4575 complete with unit test that fails without the fix and passes with the fix.