Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate /deser tests to JUnit 5 #4317

Merged

Conversation

JooHyukKim
Copy link
Member

No description provided.

@JooHyukKim JooHyukKim marked this pull request as ready for review January 14, 2024 07:38
@cowtowncoder cowtowncoder changed the title Migrate /convert tests to JUnit 5 Migrate /deser tests to JUnit 5 Jan 15, 2024
/**********************************************************
*/

public static JsonParser createParserUsingReader(String input)
Copy link
Member

@cowtowncoder cowtowncoder Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this but I think these methods should be avoided and eventually removed.

EDIT: I'll go ahead and replace usage of these methods, remove methods.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanksss!

@cowtowncoder cowtowncoder merged commit 472c9fe into FasterXML:2.17 Jan 15, 2024
6 checks passed
cowtowncoder added a commit that referenced this pull request Jan 15, 2024
@JooHyukKim JooHyukKim deleted the migrate-/deser-tests-to-JUnit-5 branch January 15, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants