Fix REQUIRE_SETTERS_FOR_GETTERS taking no effect
#4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
Dec 11, 2023
Comment on lines
397
to
401
| return (_ctorParameters != null) | ||
| || (_setters != null) | ||
| || ((_fields != null) | ||
| // [databind#736] Fix `REQUIRE_SETTERS_FOR_GETTERS` taking no effect | ||
| && (_fields.isVisible)); |
There was a problem hiding this comment.
It should be that we could deserialize if _fields not null AND is visible (I think... like private field 🤔)
|
@JooHyukKim Makes sense; my only concern is whether this could lead to ignoring some fields that might not be visible but have annotations. But none of test suite fails so I think we should be good. But I have a feeling this is too risky for 2.16 and would prefer PR against |
Agreed, and changed base 👍🏼 |
|
Thank you @JooHyukKim! Will try to get this merged soon (tomorrow). |
cowtowncoder
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #736 from way back.
Notes