Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for Record class deserialization with single field annotated with JsonProperty.Access.WRITE_ONLY #3899

Merged
merged 4 commits into from
May 3, 2023

Conversation

JooHyukKim
Copy link
Member

relates to #3897

@yihtserns
Copy link
Contributor

yihtserns commented May 3, 2023

I'm going to fix this bug, but how do I use this PR/branch?..

Do I fork from your fork?

@JooHyukKim
Copy link
Member Author

JooHyukKim commented May 3, 2023

I'm going to fix this bug, but how do I use this PR/branch?..

Do I fork from your fork?

@yihtserns Good 👍🏻👍🏻 You can just copy the test code and include it in the PR. No need to keep the test class here since you would include the test case anyway.

You can refer to below suggested git command🙆🏽‍♂️🙆🏽‍♂️

@pjfanning
Copy link
Member

use

git remote add jhk https://github.com/JooHyukKim/jackson-databind
git fetch jhk
git switch -c  jhk/Add-failing-test-for-#3897

@yihtserns
Copy link
Contributor

Copied & modified into #3910.

@cowtowncoder cowtowncoder merged commit 40b4e2a into FasterXML:2.15 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants