Fix #3992: avoid too early/eager removal of accessors

release-notes/VERSION-2.x

@@ -27,6 +27,8 @@ Project: jackson-databind
  (contributed by Joo-Hyuk K)
 #3965: Add `JsonNodeFeature.WRITE_PROPERTIES_SORTED` for sorting `ObjectNode` properties
   on serialization
+#3992: `@JsonIgnore` on Record property ignored if there is getter override
+ (reported by @ennishol)
 #4008: Optimize `ObjectNode` findValue(s) and findParent(s) fast paths
  (contributed by David S)
 #4009: Locale "" is deserialised as `null` if `ACCEPT_EMPTY_STRING_AS_NULL_OBJECT`

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

@@ -976,15 +976,18 @@ protected void _removeUnwantedProperties(Map<String, POJOPropertyBuilder> props)
             // Otherwise, check ignorals
             if (prop.anyIgnorals()) {
                 // Special handling for Records, as they do not have mutators so relying on constructors
-                // with (mostly)  implicitly-named parameters...
-                if (isRecordType()) {
-                    // ...so can only remove ignored field and/or accessors, not constructor parameters that are needed
-                    // for instantiation...
-                    prop.removeIgnored();
-                    // ...which will then be ignored (the incoming property value) during deserialization
-                    _collectIgnorals(prop.getName());
-                    continue;
-                }
+                // with (mostly) implicitly-named parameters...
+                // 20-Jul-2023, tatu: This can be harmful, see f.ex [databind#3992] so
+                //   comment out and let default handling proceed.
+
+//                 if (isRecordType()) {
+//                    // ...so can only remove ignored field and/or accessors, not constructor parameters that are needed
+//                    // for instantiation...
+//                    prop.removeIgnored();
+//                    // ...which will then be ignored (the incoming property value) during deserialization
+//                    _collectIgnorals(prop.getName());
+//                    continue;
+//                 }
 
                 // first: if one or more ignorals, and no explicit markers, remove the whole thing
                 // 16-May-2022, tatu: NOTE! As per [databind#3357] need to consider

src/test-jdk14/java/com/fasterxml/jackson/databind/records/RecordWithIgnoreOverride3992Test.java

@@ -0,0 +1,45 @@
+package com.fasterxml.jackson.databind.records;
+
+import java.util.*;
+
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.databind.BaseMapTest;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+public class RecordWithIgnoreOverride3992Test extends BaseMapTest
+{
+    // [databind#3992]
+    public record HelloRecord(String text, @JsonIgnore Recursion hidden) {
+        // Before fix: works if this override is removed
+        // After fix: works either way
+        @Override
+        public Recursion hidden() {
+            return hidden;
+        }
+    }
+
+    static class Recursion {
+        public List<Recursion> all = new ArrayList<>();
+
+        void add(Recursion recursion) {
+            all.add(recursion);
+        }
+    }
+
+    private final ObjectMapper MAPPER = newJsonMapper();
+
+    /*
+    /**********************************************************************
+    /* Test methods
+    /**********************************************************************
+     */
+
+    // [databind#3992]
+    public void testHelloRecord() throws Exception {
+        Recursion beanWithRecursion = new Recursion();
+        beanWithRecursion.add(beanWithRecursion);
+        String json = MAPPER.writer()
+                .writeValueAsString(new HelloRecord("hello", beanWithRecursion));
+        assertEquals(a2q("{'text':'hello'}"), json);
+    }
+}