Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cfg for hex values if we want upper or lowercase letters #819

Merged

Conversation

Richie94
Copy link
Contributor

@Richie94 Richie94 commented Oct 3, 2022

For issue #717 I tried to make this configurable.

Its my first PR here, I didnt found a good spot for testing, would be nice if you can point me out where to do this.

@cowtowncoder
Copy link
Member

Looks mostly good, thank you for contributing this!

As to testing, I think it should go somewhere under com.fasterxml.jackson.core.write, perhaps GeneratorBasicTest, or new test class. Should cover all implementations.

Aside from that, one thing I will need before merging (and about only thing) is CLA.
It can be found here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(or Corporate CCLA next to it).

the usual way is to print, fill & sign, scan, email to info at fasterxml dot com.
With that I can merge this and it can still make it in 2.14.0 release (or -rc2 first maybe).

Looking forward to merging this!

@Richie94
Copy link
Contributor Author

Richie94 commented Oct 3, 2022

Thx for fast feedback, ill print the CLA out tomorrow and send it to you.

@Richie94
Copy link
Contributor Author

Richie94 commented Oct 4, 2022

Okay, Mail should be in your inbox.

@cowtowncoder
Copy link
Member

CLA received, can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants