Add method in NumberInput to parse a float
#754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning I think we should go ahead and merge this in, regardless of the other issues: it seems like a basic building block we need. Issues with coercions can be tackled separately. So unless you have concerns, please convert to non-draft PR and I'll merge it? |
|
@cowtowncoder I'm happy to have this merged as a builing block. Some of the other discussions are independent and could be scala specific |
cowtowncoder
changed the title
NumberInput to parse a float
cowtowncoder
added a commit
that referenced
this pull request
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#753