Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to initial BufferRecyclerProvider PR #1085

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

cowtowncoder
Copy link
Member

Addressing issues uncovered in the first PR to add pluggable BufferRecycler pooling.

@cowtowncoder cowtowncoder marked this pull request as ready for review August 22, 2023 02:52
@cowtowncoder cowtowncoder merged commit eca76dd into 2.16 Aug 22, 2023
5 checks passed
@cowtowncoder cowtowncoder deleted the tatu/2.16/buffer-recycler-part-2 branch August 22, 2023 02:54
@mariofusco
Copy link
Contributor

@cowtowncoder Thanks a lot. I will rebase #1064 against this commit and the former one and rework it accordingly. Please don't change anything in this area in the meanwhile, or at least warn me if you have to do so.

public interface BufferRecyclerPool
extends java.io.Serializable
{
public BufferRecycler acquireBufferRecycler(TokenStreamFactory forFactory);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cowtowncoder I don't understand why this method takes a TokenStreamFactory as argument, can you please clarify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows inspecting configuration of the factory that creates parser/generator that needs recycler: mostly JsonFactory.Feature settings.
TokenStreamFactory is that abstract super-type of JsonFactory; could pass latter if that proves necessary.

@cowtowncoder
Copy link
Member Author

@cowtowncoder Thanks a lot. I will rebase #1064 against this commit and the former one and rework it accordingly. Please don't change anything in this area in the meanwhile, or at least warn me if you have to do so.

Thanks, will try to avoid/limit changes in relevant areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants