Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS pygame no hardware accelerated device error #1190

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

elliottower
Copy link
Member

Description

Master was failing, and this test only runs on push, so I'm changing it to run every PR just so we don't have any other pushing to master where it fails.

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Member Author

#1161 integrated the changes from here to test more fully

@elliottower
Copy link
Member Author

Looks like even with the sdl video driver dummy stuff it still won’t work, gonna probably just disable this so we can have master passing.

@elliottower elliottower merged commit 6609763 into master Mar 14, 2024
47 checks passed
@elliottower elliottower deleted the elliottower-patch-3 branch March 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant