Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo to be up to Farama Standards #535

Merged
merged 9 commits into from
Nov 26, 2023
Merged

Update repo to be up to Farama Standards #535

merged 9 commits into from
Nov 26, 2023

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Nov 18, 2023 •
edited
Loading

This PR adds the following QoL improvements:

  1. black, flake8, isort using a pre-commit action
    • No pydocstring and pyright yet. Too many errors cropped up.
    • Fixed a whole bunch of import problems, tests are passing, but I have no idea if any core functionality has been affected outside of the tests.
  2. Tests for Python 3.8-3.11
  3. Adds a FUNDING.yml.

@jjshoots jjshoots marked this pull request as draft November 18, 2023 13:39
@jjshoots jjshoots marked this pull request as ready for review November 18, 2023 13:57
eleurent
eleurent approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@eleurent eleurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@eleurent eleurent merged commit d0d7571 into Farama-Foundation:master Nov 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleurent eleurent eleurent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjshoots @eleurent