Issue #3 - Changed classes to be records #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majekdor
previously requested changes
Nov 4, 2021
|
Only looked at the changes in GitHub, not IntelliJ, but it all looks good to me. Waiting for review from the big boss Cassy. |
Majekdor
approved these changes
Nov 4, 2021
funnyboy-roks
requested changes
Nov 4, 2021
There was a problem hiding this comment.
After testing on our dev server, this error occurred when loading the server's pre-existing data. You can use this sample playerdata to test your code further.
|
@funnyboy-roks @Majekdor @Cassy343 So after testing a bit, I found out it's an error from Gson itself not being able to deserialize records properly, it's a known Gson issue. There are workarounds provided by the community, but the simplest fix is just to revert Birthday back to a class. |
funnyboy-roks
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed some classes in the data package to be records. I chose the classes to be converted based on how the previous code declared attributes in the class, I chose classes that declared all the attributes as final.
Then after converting those classes to records I had to change how other classes retrieved data using the generated getters from records.