-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gladiabot Teams #500
Gladiabot Teams #500
Conversation
copied form EE but the Floof implementation of the NpcFactionSystem seems to be slightly outdated
RSI Diff Bot; head commit 8b764d4 merging into 30a347c Resources/Textures/Mobs/Silicon/Bots/gladiabot.rsi
|
Resolved the issues with events not reaching the client, so now everything is working as intended, it's ready for review, and if it passes it, Gladiabots are 100% done (unless we want to allow emagging them later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, except for a few code style issues. We can probably keep the new systems in their current directories if you are planning to port this to EE.
Content.Client/NPC/Systems/NpcFactionSpriteStateSetterSystem.cs
Outdated
Show resolved
Hide resolved
Content.Client/NPC/Systems/NpcFactionSpriteStateSetterSystem.cs
Outdated
Show resolved
Hide resolved
71d13ad
to
785eb3b
Compare
Co-authored-by: Mnemotechnican <[email protected]>
Content.Client/NPC/Systems/NpcFactionSpriteStateSetterSystem.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the last issue is resolved, should be good·
…rite because of it
5d2dc76
to
8b764d4
Compare
Description
Allow players to put Gladiabots in teams.
When set in a team, the Gladiabot will change colour via a new component.
Media
20250120200833.mp4
20250120200407.mp4
Changelog
🆑 Timfa, Mnemotechnician