Prescription HUD Construction Crash Fix #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the tag "GlassesNearsight" to the tag list in tags.yml and tagged the glasses prototype with it. The crafting graph for prescription huds expects this tag.
Cprn-Sprkl
requested review from
Fansana,
Memeji and
FoxxoTrystan
as code owners
github-actions
bot
added
Status: Needs Review
|
I'll be unavailable for the next few hours so I figured I'd just submit the fix I have in case this a problem for the main server and not just an issue with my local build. |
|
Test fail should be unrelated, but I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the tag "GlassesNearsight" to the tag list in tags.yml and tagged the glasses prototype with it. The crafting graph for prescription HUDs expects this tag.
Description
The construction graph for the prescription versions of the sec and med HUDs requires an item with the tag "GlassesNearsight". This tag was not on the glasses prototype nor in the list of tags. When attempting to build a prescription HUD with the appropriate HUD, cables, and glasses, but not the glue, the local server would encounter a hard error that closed it. Other combinations were not tested.
TODO
Changelog
🆑 sprkl