Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Addition Kettle #431

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Map Addition Kettle #431

merged 8 commits into from
Dec 31, 2024

Conversation

Dunrab
Copy link
Contributor

@Dunrab Dunrab commented Dec 24, 2024

Description

Add Kettle as a playable map for mid to high pop. This station dose not include a TEG due to atmos being separate from engineering. However, engineers have a few options for power such as a Tesla, AME and the solars have been beefed up due to the lack of a TEG. If engineering wanted to they could work with logi to order more solars and run the station off of solar power if they so choose or just stick to the tesla.

The maps includes all standard jobs for departments and I added a room for a psychologist and reporters so that anyone who likes playing those jobs can play them. I also mapped two shadowkin portals and set the job amount of Anomaly's to be four but that can be tweaked as needed.

I did not add Kettle to the map pool as I'm not sure if there is a want to test the map further than just me testing it on my own.


TODO

  • Add missing things for epi (such as prober and mantis jobs)
  • Add room for reporters
  • Add room for psychologist
  • Add Cryo sleep since this map did not have any
  • Add Prisoner jobs and their cryosleep pods
  • Make sure arrivals & evac dock to the station properly
  • Upload the kettle.yml for the jobs

Media

Kettle Map Render


Changelog

🆑

  • add: Added Kettle as a mid pop map

add kettle as a playable mid pop map
other file for the map to work
Forgot to change the map path to /Maps/Floof/
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Map Changes any yml file in the Maps directories Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Dec 24, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Map addition kettle Map Addition Kettle Dec 24, 2024
@FoxxoTrystan FoxxoTrystan added the Priority: 2-Medium Needs to be resolved at some point label Dec 26, 2024
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails valid.

Dont forget to add your map in the Intergration Test.

PostMapInitTest.cs

forgot to add kettle to PostMapInitTest.cs
@github-actions github-actions bot added the Changes: C# Changes any cs files label Dec 26, 2024
@Dunrab
Copy link
Contributor Author

Dunrab commented Dec 26, 2024

ah first time I have added a new map, just added it will keep that in mind for the future

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Fails is valid, please check the test fail and fix the issue.

second attempt to fix the test
adding missing jobspawns to hopefully fix the test.
added missing thing to the library
@Dunrab Dunrab requested a review from FoxxoTrystan December 30, 2024 21:08
added the station anchor
replaced Janitor locker with LockerJanitorFilled
replaced Clown locker with LockerClownFilled
replaced Mime locker LockerMimeFilled
replaced Bartender locker LockerBartenderFilled
Copy link
Collaborator

@Memeji Memeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to test this map out!

@Dunrab
Copy link
Contributor Author

Dunrab commented Dec 31, 2024

its one of my favorite older maps im curious to see if engineering/atmos will build the "bridge" between medbay and the bar like we used to see on wizden all time and im also curious how everyone will like or dislike atmos being separate from engineering.

@Fansana Fansana merged commit 87c9688 into Fansana:master Dec 31, 2024
11 checks passed
Floof-Station-Bot added a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Map Changes any yml file in the Maps directories Changes: YML Changes any yml files Priority: 2-Medium Needs to be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants