Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update Next.js, React.js and Node.js #815

Merged
merged 38 commits into from
Jun 23, 2024
Merged

refactor: update Next.js, React.js and Node.js #815

merged 38 commits into from
Jun 23, 2024

Conversation

gauthier-th
Copy link
Collaborator

@gauthier-th gauthier-th commented Jun 13, 2024 •
edited
Loading

Description

This PR updates Next.js, React.js and Node.js to their latest version.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

gauthier-th and others added 15 commits June 14, 2024 00:42
@gauthier-th
refactor: update Next.js and React.js
9ab5fa5
@gauthier-th
refactor: update Next.js images
63d8f55
@gauthier-th
refactor: update ESLint rules and fix warnings/errors
c680202
@gauthier-th
fix: remove old intl polyfill
5d6e7f0
@gauthier-th
fix: add proper size to next/image components
48d178c
@gauthier-th
fix: adjust full-size for next/image components
65239a9
@gauthier-th
fix: temporary allow all domains for image optimization
5fb1c68
@Fallenbagel
build: fixes an issue where dev env could lead to javascript heap out…
06e465d 
… of memory
@gauthier-th
chore: merge origin/develop
cb8cada
@gauthier-th
fix: resolve webpack cache issue with country-flag-icons
5efa1d7
@gauthier-th
refactor: switch compiler from Babel to SWC
6b248d9
@gauthier-th
fix: resize logo in sidebar
5c212ae
@gauthier-th
fix: break word on long path to avoid text overflow
f7de241
@Fallenbagel
chore: added sharp for production image optimisation
5070000
@gauthier-th
fix: change extract script for i18n to a custom script
43f8260
@gauthier-th gauthier-th marked this pull request as ready for review June 21, 2024 17:14
@Fallenbagel Fallenbagel mentioned this pull request Jun 21, 2024
Open
9 tasks
@Alacard
Copy link

Alacard commented Jun 23, 2024

found a small bug with the requester profile icon not being resized correctly under recent requests.

342007805-d77242fb-f5af-40f0-a473-27469a0710fb

@gauthier-th
Copy link
Collaborator Author

found a small bug with the requester profile icon not being resized correctly under recent requests.

342007805-d77242fb-f5af-40f0-a473-27469a0710fb

This should be fixed

@gauthier-th gauthier-th changed the title refactor: update Next.js and React.js refactor: update Next.js, React.js and Node.js Jun 23, 2024
@Gauvino
Copy link
Contributor

Gauvino commented Jun 23, 2024

First bug on request page the collection at the too same button with one not being displayed properly.
chrome_fifRtACbbJ
Second one appears not on everyone, in the request menu some picture of profile I think of requester are not rendered properly and break the request card. (Note: the render of broken profile picture only occurred in request car on request slide)
chrome_GZozC4Ik0P
chrome_oZVlqrTIQc

And that's is for the graphical side I think, I haven't encountered any other problems !

Thank you for all this amazing work really !

@gauthier-th
Copy link
Collaborator Author

First bug on request page the collection at the too same button with one not being displayed properly. chrome_fifRtACbbJ Second one appears not on everyone, in the request menu some picture of profile I think of requester are not rendered properly and break the request card. (Note: the render of broken profile picture only occurred in request car on request slide) chrome_GZozC4Ik0P chrome_oZVlqrTIQc

And that's is for the graphical side I think, I haven't encountered any other problems !

Thank you for all this amazing work really !

Thanks for reporting this! It should be fixed now.

@Gauvino
Copy link
Contributor

Gauvino commented Jun 23, 2024

Bug fixed, and everything seems to be working fine, interaction, menu, card, everything is great.
Thanks for everything

@Fallenbagel
build: migrate yarn to pnpm and restrict engine to node@^20.0.0
99ee19c
@Fallenbagel
ci: specify the pnpm version to use in workflow actions
588b1e3
@Fallenbagel
ci: fix typo in pnpm action-setup for cypress workflow
cb7e2f0
@Fallenbagel
test(cypress): use pnpm instead of yarn
ffb20eb
@Fallenbagel
style: ran prettier on pnpm-lock
878afb9
@Fallenbagel
ci(cypress): setup nodejs v20 in cypress workflow
e50df22
@Fallenbagel
ci: pnpm cache to reduce install time
37ba36f
@Fallenbagel
ci: use sh shell to get pnpm store directory
a58811e
@Fallenbagel
build(dockerfile): migrate to pnpm from yarn in docker builds
182aeaa
@Fallenbagel
build(dockerfile): copy the proper pnpm lockfile
1168c77
@Fallenbagel
build: install pnpm for all platforms
2c52dbc
@Fallenbagel
build(dockerfile): remove unnecessary && on apk installation steps
cc80bf2
@Fallenbagel
build: migrate pnpm 8 to 9
e30a3ea
@Fallenbagel
build(dockerfile): add node-gyp back in
f5a5091
@Fallenbagel
build(dockerfile): install node-gyp through npm
d5e37e4
@Fallenbagel
build(dockerfile): ignore scripts to not run husky install when devde…
0da85ca 
…pendencies are pruned
Fallenbagel
Fallenbagel reviewed Jun 23, 2024
View reviewed changes
Dockerfile.local Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/components/IssueBlock/index.tsx Show resolved Hide resolved
src/components/ResetPassword/RequestResetLink.tsx Show resolved Hide resolved
src/components/ResetPassword/index.tsx Show resolved Hide resolved
src/components/Settings/Notifications/NotificationsWebhook/index.tsx Show resolved Hide resolved
src/components/UserProfile/ProfileHeader/index.tsx Show resolved Hide resolved
src/components/UserProfile/ProfileHeader/index.tsx Show resolved Hide resolved
Fallenbagel
Fallenbagel previously approved these changes Jun 23, 2024
View reviewed changes
Fallenbagel
Fallenbagel approved these changes Jun 23, 2024
View reviewed changes
Copy link
Owner

@Fallenbagel Fallenbagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthier-th gauthier-th merged commit 989af67 into develop Jun 23, 2024
7 checks passed
@Fallenbagel Fallenbagel deleted the update-nextjs branch June 30, 2024 00:32
@Fallenbagel
Copy link
Owner

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fallenbagel Fallenbagel Fallenbagel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jemalloc page size issue for arm64
4 participants
@gauthier-th @Alacard @Gauvino @Fallenbagel