Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option on item's page to add/remove from watchlist #781

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

JoaquinOlivero
Copy link
Contributor

re #730

Description

Adds a button on the individual media item's page to add or remove it from the user's watchlist.

Screenshot (if UI-related)

output

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

src/i18n/locale/en.json Outdated Show resolved Hide resolved
src/components/MovieDetails/index.tsx Outdated Show resolved Hide resolved
src/components/MovieDetails/index.tsx Outdated Show resolved Hide resolved
src/components/TvDetails/index.tsx Outdated Show resolved Hide resolved
src/components/TvDetails/index.tsx Outdated Show resolved Hide resolved
src/i18n/locale/en.json Outdated Show resolved Hide resolved
src/i18n/locale/en.json Outdated Show resolved Hide resolved
src/i18n/locale/en.json Outdated Show resolved Hide resolved
src/i18n/locale/en.json Outdated Show resolved Hide resolved
gauthier-th
gauthier-th previously approved these changes May 31, 2024
Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this nice feature :)

Fallenbagel
Fallenbagel previously approved these changes May 31, 2024
@Gauvino
Copy link
Contributor

Gauvino commented May 31, 2024

Could I just run the PR myself to see if everything ok before merging?

@gauthier-th
Copy link
Collaborator

Could I just run the PR myself to see if everything ok before merging?

Go ahead

Copy link
Contributor

@Gauvino Gauvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Jun 23, 2024
@github-actions github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Jul 10, 2024
@gauthier-th gauthier-th merged commit 2348f23 into Fallenbagel:develop Aug 7, 2024
8 checks passed
@Fallenbagel
Copy link
Owner

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to add item to Watchlist from actual item page
4 participants