Add files via upload #100
Merged
Add files via upload #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for issue #35
liamhyde02
requested changes
Nov 14, 2023
DhillonTaran
changed the base branch from
35-feat-get-the-name-for-all-classes-a-java-entity-extends
to
mainline
liamhyde02
requested changes
Nov 15, 2023
| @Override | ||
| public JavaEntity construct(EntityBuilder builder, CompilationUnit declaration) { | ||
| // Existing logic to parse the entity | ||
| JavaEntity entity = next.construct(builder, declaration); |
There was a problem hiding this comment.
you don't need to parse the entity here, just put everything into the builder
| Set<String> associatedClassNames = getAssociatedClassNames(entity); | ||
| associatedClassNames.forEach(builder::addAssociation); | ||
|
|
||
| return entity; |
There was a problem hiding this comment.
need to return next.construct here
buk0vec
requested changes
Nov 15, 2023
| @Override | ||
| public JavaEntity construct(EntityBuilder builder, CompilationUnit declaration) { | ||
| // Existing logic to parse the entity | ||
| JavaEntity entity = next.construct(builder, declaration); |
There was a problem hiding this comment.
Call this at the end of the function!
There was a problem hiding this comment.
Otherwise it will run out of order. Just look at the other steps
| return entity; | ||
| } | ||
|
|
||
| private Set<String> getAssociatedClassNames(Object entity) { |
There was a problem hiding this comment.
Isn't your task to just get the parent class of the ClassOrInterfaceDeclaration if it has one? Kind of confused on why all this logic is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #35