Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request trigger to the build workflow #37

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SunSerega
Copy link

I recently figured out with munix that the push trigger created GitHub Action in the repo that had the push.
So if the commit is pushed to my fork, no Action is created in this repo and so my PR doesn't have the "Checks successful" badge:
https://discord.com/channels/1078696971088433153/1078841771771056280/1215255763518230528

Btw, this is already fixed in the latest version of the template.
And I see you somehow already updated the template before, right?
Mind sharing your process for this kind of update? I've set up this for myself, but now I'm thinking if there was an easier route...

@SunSerega
Copy link
Author

Ah, you can also need to go to:
https://github.com/Falki-git/MicroEngineer/settings/actions
And set Fork pull request workflows from outside collaborators to Require approval for first-time contributors who are new to GitHub.
It's on Require approval for first-time contributors by default just in case, but allowing new contributors to run build.yml on your repo can't really be a vulnerability...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant