Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to only show local commits #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Teszko
Copy link
Contributor

@Teszko Teszko commented Jan 30, 2017

Added an option -l/--local to show only commits that are ahead of origin/{branch}.
For this I introduced the function set_log_command() to select a different command template as it makes little sense to filter author and date in combination with -local, at least by default. The command is expected to show ALL commits ahead of the remote branch.

One thing I don't like is the error handling for the git log command.
COMMITS=($(eval ${GIT_LOG} 2>/dev/null))
when using the -local option and the branch origin/{branch} does not exist yet (as is the case if you
just created the new branch and didn't push anything yet) the error does not get caught and instead
the "did nothing during this period" message is shown. So error handling should be added, but
that goes beyond this PR.

Teszko and others added 2 commits January 30, 2017 16:04
@Teszko
Copy link
Contributor Author

Teszko commented Jan 31, 2017

  • updated documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant