Skip to content

Commit

Permalink
surface any errors encountered during schema validation (#672)
Browse files Browse the repository at this point in the history
  • Loading branch information
sudermanjr authored Mar 2, 2023
1 parent e326a9b commit 1b82cb8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/course/course.go
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ func OpenCourseFile(fileName string, schema []byte) (*FileV2, error) {

if err := courseFile.validateJsonSchema(schema); err != nil {
klog.V(3).Infof("failed to validate jsonSchema in course file: %s", fileName)
return nil, SchemaValidationError
return nil, err
}

return courseFile, nil
Expand Down Expand Up @@ -562,12 +562,12 @@ func (f *FileV2) validateJsonSchema(schemaData []byte) error {

jsonData, err := json.Marshal(f)
if err != nil {
return SchemaValidationError
return err
}

result, err := schema.Validate(gojsonschema.NewBytesLoader(jsonData))
if err != nil {
return SchemaValidationError
return err
}
if len(result.Errors()) > 0 {
for _, err := range result.Errors() {
Expand Down

0 comments on commit 1b82cb8

Please sign in to comment.