Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename pdbMinAvailableGreaterThanHPAMinReplicas to pdbMinAvailableGre… #1073

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

YuMuuu
Copy link

@YuMuuu YuMuuu commented Oct 3, 2024

This PR fixes #1071

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

What changes did you make?

What alternative solution should we consider, if any?

  • I couldn't connect to circle ci for some reason so I ran test local only/

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2024

CLA assistant check
All committers have signed the CLA.

@vitorvezani
Copy link
Member

Hi @YuMuuu, thanks for your contribution!

After reviewing the changes and discussing internally, we believe this update introduces a breaking change. To avoid impacting current Polaris clients, we suggest the following approach:

  • Retain the current check, but modify its logic (and docs) to check only for >, instead
  • Introduce a complementary check that specifically handles the = case.

Both changes we plan to release in a new minor version.
This approach ensures compatibility with existing clients while addressing the functionality you're aiming for.

I understand this may require additional changes to your PR. Please let me know if you have the bandwidth to make these adjustments, or if you'd prefer someone else to take it from here.

Thanks again for your efforts!

@YuMuuu YuMuuu marked this pull request as ready for review October 3, 2024 20:09
@YuMuuu
Copy link
Author

YuMuuu commented Oct 4, 2024

@vitorvezani
Thanks for your reply. I agree with your idea. I’ll keep the name pdbMinAvailableGreaterThanHPAMinReplicas, fix logic, and create other complement validation.
I’d like to fix the PR as you mentioned, but it might take time because I’m not a golang expert.

This reverts commit faffffc.
…lableGreaterThanOrEqualToHPAMinReplicas"

This reverts commit b93f283.
@YuMuuu YuMuuu force-pushed the rename-pdbMinAvailableGreaterThanHPAMinReplicas branch from 79628dc to 94863f3 Compare October 4, 2024 01:19
@YuMuuu YuMuuu force-pushed the rename-pdbMinAvailableGreaterThanHPAMinReplicas branch from 94863f3 to 701c6f0 Compare October 4, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdbMinAvailableGreaterThanHPAMinReplicas validation is actually a greater or equal then comparison
3 participants