feat(react): upgrade dev dependency to react 18 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianyyang
approved these changes
Jun 4, 2024
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update regarding #115 to ensure mjml-react is compatibile with React 19
Part of React 19 upgrade guide is to first upgrade to React 18.3 to help identify any issues.
The upgrade to react 18.3 did not cause any changes when generating or building the mjml-react files. It did however cause some type errors on a few of the extensions. This was easily solved by explicitly defining the
childrenprop.React itself is still a peer dependency of mjml-react, and this update should be backwards compatible