Skip to content

Commit

Permalink
dds-slurm-plugin: Fixed: fixed path to demonised log file.
Browse files Browse the repository at this point in the history
- This log is created if plug-in failed to start
  • Loading branch information
AnarManafov committed Feb 22, 2021
1 parent fcb0ad1 commit 2868c23
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions ReleaseNotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Modified: improved default SID storage and handling. (GH-318)

### dds-slurm-plugin
Fixed: a couple of fixes in Slurm plugin found on a Virgo cluster.
Fixed: fixed path to demonised log file. This log is created if plug-in failed to start.

## v3.4 (2020-07-01)

Expand Down
2 changes: 1 addition & 1 deletion dds-daemonize/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,4 @@ int main(int argc, char* argv[])
execvp(argv[2], cmd_arg);

return 0;
}
}
4 changes: 2 additions & 2 deletions plugins/dds-submit-lsf/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,15 @@ int main(int argc, char* argv[])
fs::path pathlsfScript(pathPluginDir);
pathlsfScript /= "dds-submit-lsf-worker";
stringstream cmd;
cmd << "$DDS_LOCATION/bin/dds-daemonize " << pathPluginDir.string() << " /bin/bash -c \""
cmd << "$DDS_LOCATION/bin/dds-daemonize " << sSandboxDir << " /bin/bash -c \""
<< pathlsfScript.string() << "\"";

proto.sendMessage(dds::intercom_api::EMsgSeverity::info, "Preparing job submission...");
string output;
pid_t exitCode = execute(cmd.str(), chrono::seconds(30), &output);

// In case of error there can be a bash.out.log created, let's check it's content
fs::path pathBashlog(pathPluginDir);
fs::path pathBashlog(sSandboxDir);
pathBashlog /= "bash.out.log";

if (exitCode == 0)
Expand Down
4 changes: 2 additions & 2 deletions plugins/dds-submit-pbs/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,15 @@ int main(int argc, char* argv[])
fs::path pathPBSScript(pathPluginDir);
pathPBSScript /= "dds-submit-pbs-worker";
stringstream cmd;
cmd << "$DDS_LOCATION/bin/dds-daemonize " << pathPluginDir.string() << " /bin/bash -c \""
cmd << "$DDS_LOCATION/bin/dds-daemonize " << sSandboxDir << " /bin/bash -c \""
<< pathPBSScript.string() << "\"";

proto.sendMessage(dds::intercom_api::EMsgSeverity::info, "Preparing job submission...");
string output;
pid_t exitCode = execute(cmd.str(), chrono::seconds(30), &output);

// In case of error there can be a bash.out.log created, let's check it's content
fs::path pathBashlog(pathPluginDir);
fs::path pathBashlog(sSandboxDir);
pathBashlog /= "bash.out.log";

if (exitCode == 0)
Expand Down
4 changes: 2 additions & 2 deletions plugins/dds-submit-slurm/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -183,15 +183,15 @@ int main(int argc, char* argv[])
fs::path pathSLURMScript(pathPluginDir);
pathSLURMScript /= "dds-submit-slurm-worker";
stringstream cmd;
cmd << "$DDS_LOCATION/bin/dds-daemonize " << pathPluginDir.string() << " /bin/bash -c \""
cmd << "$DDS_LOCATION/bin/dds-daemonize " << sSandboxDir << " /bin/bash -c \""
<< pathSLURMScript.string() << "\"";

proto.sendMessage(dds::intercom_api::EMsgSeverity::info, "Preparing job submission...");
string output;
pid_t exitCode = execute(cmd.str(), chrono::seconds(30), &output);

// In case of error there can be a bash.out.log created, let's check it's content
fs::path pathBashlog(pathPluginDir);
fs::path pathBashlog(sSandboxDir);
pathBashlog /= "bash.out.log";

if (exitCode == 0)
Expand Down

0 comments on commit 2868c23

Please sign in to comment.