Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sara-r5 #89

Merged
merged 5 commits into from
Oct 14, 2023
Merged

fix sara-r5 #89

merged 5 commits into from
Oct 14, 2023

Conversation

tarfu
Copy link
Contributor

@tarfu tarfu commented Oct 3, 2023

Related to #88.

@tarfu tarfu marked this pull request as ready for review October 4, 2023 12:46
@tarfu
Copy link
Contributor Author

tarfu commented Oct 4, 2023

It does compile for me now, with features sara-r5 and defmt-impl. I can't get it to run properly, but if it does need changes, I would open another PR.
But I can also collect all changes until it works here if that is better for you.

@tarfu
Copy link
Contributor Author

tarfu commented Oct 8, 2023

Would also add FactbirdHQ/atat#171 to here

@tarfu
Copy link
Contributor Author

tarfu commented Oct 9, 2023

Also will add this here FactbirdHQ/ublox-sockets#18 so that the versions are in sync

@tarfu
Copy link
Contributor Author

tarfu commented Oct 11, 2023

@MathiasKoch I think this could be merged. It builds and seems to work. I would open another PR to bring it to live on embassy with only one executor and add some async functions for everything that writes stuff or has sleeps.

Currently, it sends plenty of commands to init AT, but then the ingress would only read them after it is too late.

@tarfu
Copy link
Contributor Author

tarfu commented Oct 11, 2023

The async one could be a real big PR looking into it this evening. ...

@MathiasKoch
Copy link
Member

Closes #88

@MathiasKoch MathiasKoch linked an issue Oct 14, 2023 that may be closed by this pull request
@MathiasKoch
Copy link
Member

@tarfu Could you make the CI green :)

@tarfu
Copy link
Contributor Author

tarfu commented Oct 14, 2023

@MathiasKoch Should be done.

@MathiasKoch MathiasKoch added this pull request to the merge queue Oct 14, 2023
Merged via the queue into FactbirdHQ:master with commit 5299a76 Oct 14, 2023
4 checks passed
MathiasKoch pushed a commit that referenced this pull request Oct 22, 2023
* fix sara-r5 (#89)

* fix imports and Features Enum for sara-r5

* update ublox-sockets

* implement defmt::format

* enable defmt for nb and bump embedded-io,ublox-sockets,atat

* rustfmt

* Buildable withouth sockets

* rustfmt

* only use defmt feature not defmt-impl in ci

* remove atat feature defmt as default

* init module

* enable to remove atat from ublox-sockets

* make config public

* add example

* correct version override

* add build.rs to embassy-stm32-example

* running example

* add power up and power down

* Add ReverseOutputPin and ReverseInputPin to cope with the switched active state of some boards for pwr_on pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build for sara-r5 fails
2 participants