Only handle URCs in one place (#84) #68
github-merge-queue[bot]Annotations
11 warnings
|
field `act` is never read:
ublox-cellular/src/registration.rs#L131
warning: field `act` is never read
--> ublox-cellular/src/registration.rs:131:5
|
128 | pub struct RegistrationParams {
| ------------------ field in this struct
...
131 | act: RatAct,
| ^^^
|
= note: `RegistrationParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
methods `started` and `updated` are never used:
ublox-cellular/src/registration.rs#L38
warning: methods `started` and `updated` are never used
--> ublox-cellular/src/registration.rs:38:12
|
23 | impl CellularRegistrationStatus {
| ------------------------------- methods in this implementation
...
38 | pub fn started(&self) -> Option<Instant> {
| ^^^^^^^
...
42 | pub fn updated(&self) -> Option<Instant> {
| ^^^^^^^
|
|
function `kill_time` is never used:
ublox-cellular/src/module_timing.rs#L41
warning: function `kill_time` is never used
--> ublox-cellular/src/module_timing.rs:41:8
|
41 | pub fn kill_time() -> Option<Duration> {
| ^^^^^^^^^
|
|
field `urc_channel` is never read:
ublox-cellular/src/client.rs#L67
warning: field `urc_channel` is never read
--> ublox-cellular/src/client.rs:67:5
|
64 | pub struct Device<'buf, 'sub, AtCl, AtUrcCh, Config, const N: usize, const L: usize> {
| ------ field in this struct
...
67 | urc_channel: &'buf AtUrcCh,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused variable: `profile_id`:
ublox-cellular/src/services/data/mod.rs#L396
warning: unused variable: `profile_id`
--> ublox-cellular/src/services/data/mod.rs:396:52
|
396 | fn activate_context(&mut self, cid: ContextId, profile_id: ProfileId) -> nb::Result<(), Error> {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_id`
|
|
unused variable: `check_urc`:
ublox-cellular/src/network.rs#L434
warning: unused variable: `check_urc`
--> ublox-cellular/src/network.rs:434:9
|
434 | check_urc: bool,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_check_urc`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unused import: `command::Urc`:
ublox-cellular/src/services/data/mod.rs#L22
warning: unused import: `command::Urc`
--> ublox-cellular/src/services/data/mod.rs:22:5
|
22 | command::Urc,
| ^^^^^^^^^^^^
|
|
unused imports: `PROFILE_ID`, `self`:
ublox-cellular/src/network.rs#L13
warning: unused imports: `PROFILE_ID`, `self`
--> ublox-cellular/src/network.rs:13:13
|
13 | self, types::PDPContextStatus, GetEPSNetworkRegistrationStatus,
| ^^^^
...
20 | services::data::{ContextState, PROFILE_ID},
| ^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unneeded sub `cfg` when there is only one condition:
ublox-cellular/src/client.rs#L415
warning: unneeded sub `cfg` when there is only one condition
--> ublox-cellular/src/client.rs:415:15
|
415 | #[cfg(any(feature = "toby-r2"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "toby-r2"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
|
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Build & Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|