-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose Session trait and remove all the logic below the application-layer #20
Closed
Commits on Dec 18, 2020
-
Remove unused lifetime 'a from handlers
Kei Shirakizawa committedDec 18, 2020 Configuration menu - View commit details
-
Copy full SHA for 86a9152 - Browse repository at this point
Copy the full SHA 86a9152View commit details -
Kei Shirakizawa committed
Dec 18, 2020 Configuration menu - View commit details
-
Copy full SHA for e808c3e - Browse repository at this point
Copy the full SHA e808c3eView commit details
Commits on Dec 19, 2020
-
Kei Shirakizawa committed
Dec 19, 2020 Configuration menu - View commit details
-
Copy full SHA for 72156f9 - Browse repository at this point
Copy the full SHA 72156f9View commit details -
Get it work with ublox-cellular
Kei Shirakizawa committedDec 19, 2020 Configuration menu - View commit details
-
Copy full SHA for c73d3b1 - Browse repository at this point
Copy the full SHA c73d3b1View commit details
Commits on Dec 20, 2020
-
An attempt to support multiple packets in a receiving buffer
Kei Shirakizawa committedDec 20, 2020 Configuration menu - View commit details
-
Copy full SHA for acbd81b - Browse repository at this point
Copy the full SHA acbd81bView commit details -
Move the event struct to eventloop module
Kei Shirakizawa committedDec 20, 2020 Configuration menu - View commit details
-
Copy full SHA for 4460d6e - Browse repository at this point
Copy the full SHA 4460d6eView commit details
Commits on Dec 21, 2020
-
Kei Shirakizawa committed
Dec 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 0a9b6f8 - Browse repository at this point
Copy the full SHA 0a9b6f8View commit details
Commits on Jan 7, 2021
-
Remove all the logic below the application-layer
MQTT is defined on top of the applicaiton-layer and all that it requires is an active session. We can simplify the logic by assuming a user has performed connection to a broker in advance and supplies the session. It is nice and kind of the `rumqtt` client implementation where it takes care of all the TLS connection building, like CA and certs. However it is only possible because of `tokio_tls` and not the case for embedded environment.
Kei Shirakizawa committedJan 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 04c8acb - Browse repository at this point
Copy the full SHA 04c8acbView commit details -
Although it look pedantic I propose a session trait encapsulating network transaction in general. One downside of the `TcpClient` trait is that it only allows a single socket type. On the other hand, the `Session` trait can be implemented by multiple transaction types and they can share the same driver type of `TcpClient`.
Kei Shirakizawa committedJan 7, 2021 Configuration menu - View commit details
-
Copy full SHA for ec77c36 - Browse repository at this point
Copy the full SHA ec77c36View commit details -
Fix unit test cases and examples
Kei Shirakizawa committedJan 7, 2021 Configuration menu - View commit details
-
Copy full SHA for ddd1525 - Browse repository at this point
Copy the full SHA ddd1525View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.