Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose Session trait and remove all the logic below the application-layer #20

Closed
wants to merge 10 commits into from

Commits on Dec 18, 2020

  1. Remove unused lifetime 'a from handlers

    Kei Shirakizawa committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    86a9152 View commit details
    Browse the repository at this point in the history
  2. Update embedded-nal to v0.2.0

    Kei Shirakizawa committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    e808c3e View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. Compiles somehow

    Kei Shirakizawa committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    72156f9 View commit details
    Browse the repository at this point in the history
  2. Get it work with ublox-cellular

    Kei Shirakizawa committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    c73d3b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. An attempt to support multiple packets in a receiving buffer

    Kei Shirakizawa committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    acbd81b View commit details
    Browse the repository at this point in the history
  2. Move the event struct to eventloop module

    Kei Shirakizawa committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    4460d6e View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Add a unit test

    Kei Shirakizawa committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    0a9b6f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Remove all the logic below the application-layer

    MQTT is defined on top of the applicaiton-layer and all that it requires is an
    active session. We can simplify the logic by assuming a user has performed
    connection to a broker in advance and supplies the session.
    
    It is nice and kind of the `rumqtt` client implementation where it takes care of
    all the TLS connection building, like CA and certs. However it is only possible
    because of `tokio_tls` and not the case for embedded environment.
    Kei Shirakizawa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    04c8acb View commit details
    Browse the repository at this point in the history
  2. Propose Session trait

    Although it look pedantic I propose a session trait encapsulating network
    transaction in general. One downside of the `TcpClient` trait is that it only
    allows a single socket type. On the other hand, the `Session` trait can be
    implemented by multiple transaction types and they can share the same driver
    type of `TcpClient`.
    Kei Shirakizawa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ec77c36 View commit details
    Browse the repository at this point in the history
  3. Fix unit test cases and examples

    Kei Shirakizawa committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ddd1525 View commit details
    Browse the repository at this point in the history