Propose Session trait and remove all the logic below the application-layer #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 18, 2020 14:09
MQTT is defined on top of the applicaiton-layer and all that it requires is an active session. We can simplify the logic by assuming a user has performed connection to a broker in advance and supplies the session. It is nice and kind of the `rumqtt` client implementation where it takes care of all the TLS connection building, like CA and certs. However it is only possible because of `tokio_tls` and not the case for embedded environment.
Although it look pedantic I propose a session trait encapsulating network transaction in general. One downside of the `TcpClient` trait is that it only allows a single socket type. On the other hand, the `Session` trait can be implemented by multiple transaction types and they can share the same driver type of `TcpClient`.
keisrk
changed the title
|
I will get to reviewing this and your other PRs, but at the moment i have gotten STRICT orders from Finn, not to add ANY new code, until we have fully verified that the connection state handling is as good as it needs to be. Thus i am pushing the reviews until they are applicable. They do look sound at first sight though. 👍 |
|
Fully understood. For the time being we should focus on testing existing code base. Thanks for your comment :) |
Open
|
@keisrk Could you rebase this, so i can test it out? |
MathiasKoch
force-pushed
the
master
branch
7 times, most recently
from
2444b8d
to
369237b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it looks pedantic I propose a session trait encapsulating network
transaction in general. One downside of the
TcpClienttrait is that it onlyallows a single socket type. The
Sessiontrait is meant to be implemented bymultiple transaction types and they can share the same driver type of
TcpClient.MQTT is defined on top of the applicaiton-layer and all that it requires is an
active session. We can simplify the logic by assuming a user has performed
connection to a broker in advance and supplies the session only.
It is nice and kind of the
rumqttclient implementation where it takes care ofall the TLS connection building, like CA and certs. However it is only possible
because of
tokio_tlsand not the case for our embedded environment.