Tictactoe #144
Merged
Tictactoe #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main changes are: - removed tictactoe.o files - rewrote the lection and combined the old chapters 17 and 19 to one - modified the tictactoe.cpp file to reflect the desing changes in the lection - tbd: adjust makefile
fschledorn
added
the
fix_before_vorkurs25
Plebysnacc
requested changes
Sep 30, 2024
Co-authored-by: Tim Grube <[email protected]>
Co-authored-by: Tim Grube <[email protected]>
Co-authored-by: Tim Grube <[email protected]>
Co-authored-by: Tim Grube <[email protected]>
Co-authored-by: Tim Grube <[email protected]>
Co-authored-by: Tim Grube <[email protected]>
Co-authored-by: Tim Grube <[email protected]>
fschledorn
commented
Sep 30, 2024
calvalre
requested changes
Oct 2, 2024
…s under g++ not clang/llvm for some reason I have to find out in a second
|
will do review tmrrw |
fschledorn
commented
Oct 3, 2024
|
|
||
| int main() { | ||
| // Setup | ||
| std::array<int, 9> spielfeld{0}; |
There was a problem hiding this comment.
This does currently not compile on Apple LLVM/Clang as they have not yet fully implemented the C++ 20 Standard. As normal LLVM-Clang has implemented aggregate Initialisation as far back as 2022 and g++ supports this as well, I have decided to ignore this issue.
A possible fix could be to just initialise it using a for-loop, but I’m lazy so instead of fixing this by writing 3 lines I will write 20 lines ranting here
There was a problem hiding this comment.
I'd open an Issue for this and wait how far the homebrew clang got next year
Plebysnacc
approved these changes
Oct 5, 2024
|
|
||
| int main() { | ||
| // Setup | ||
| std::array<int, 9> spielfeld{0}; |
There was a problem hiding this comment.
I'd open an Issue for this and wait how far the homebrew clang got next year
|
lgtm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are:
lection
The build process is supposed to fail at this stage. It will only build later after all chapters have been updated