Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ents/player.Iterator instead of GetAll #2073

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aStonedPenguin
Copy link
Contributor

Self explanatory.

@Kefta
Copy link
Contributor

Kefta commented Apr 6, 2024

Great fixes on the inverse conditions.

@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Apr 19, 2024
@robotboy655
Copy link
Collaborator

This depends on Facepunch/garrysmod-issues#5800 getting solved first.

@mgetJane
Copy link
Contributor

mgetJane commented Apr 21, 2024

This depends on Facepunch/garrysmod-issues#5800 getting solved first.

player.Iterator should be unaffected by this

@aStonedPenguin imo you should make a new pr containing only the player.Iterator() changes

@storm37000
Copy link
Contributor

Tested player.GetBySteamID and player.GetBySteamID64 in singleplayer and both are 200-300% faster. Both had similar gains so im assuming the other functions that have the player.Iterator replacement will be similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The pull request enhances current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants