Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suppressing or overriding halo rendering #1944

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Python1320
Copy link
Contributor

May be used to reimplement halos without having to override the library or for situations where halos may be clashing with aesthetics or rendering (better to hide halos temporarily than have them glow through areas or force people to hook the halo library).

@Kefta
Copy link
Contributor

Kefta commented Feb 12, 2023

Add parentheses around the if condition.

@robotboy655 robotboy655 added the Addition The pull request adds new functionality. label Apr 17, 2023
@storm37000
Copy link
Contributor

storm37000 commented Mar 27, 2024

List will memory leak really badly if you stop the hook at that position. Halos would still be added with Add function but not cleared from the list.

You can override the Add function to effectively stop halos.

@garryspins
Copy link

Should probably use a new hook, CanDrawHalo(entry) for verbosity and backwards compatibility sake as some random addon might return false making issues hard to diagnose in the event of this being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Addition The pull request adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants