Skip serializing structs if default value #3
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to DeltaSerialize()
Rohansi
reviewed
Jun 19, 2024
Comment on lines
+279
to
+283
| // For some reason Ray isn't comparible so just check it's fields | ||
| if (f.ProtoTypeName == "Ray") | ||
| { | ||
| cw.IfBracket( $"instance.{f.CsName}.origin != default && instance.{f.CsName}.direction != default" ); | ||
| } |
There was a problem hiding this comment.
Were all the other Unity types in Common.proto tested? This could be generated rather than hard coded since all that info is there.
There was a problem hiding this comment.
Double check that it builds cause I got some random compile error trying to check if jobHandle == default. Only when building - not in the editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already skip serializing classes that are null inside the Serialize() method, this also skips when structs are their default value.
More details in https://app.asana.com/0/1132883489782263/1207448248246156