Add BEFORE_SPAWN event
#2975
Open
Add BEFORE_SPAWN event
#2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
suggested changes
Mar 16, 2023
...tity-events-v1/src/main/java/net/fabricmc/fabric/api/entity/event/v1/ServerPlayerEvents.java
Outdated
Show resolved
Hide resolved
...tity-events-v1/src/main/java/net/fabricmc/fabric/api/entity/event/v1/ServerPlayerEvents.java
Outdated
Show resolved
Hide resolved
...ntity-events-v1/src/main/java/net/fabricmc/fabric/mixin/entity/event/PlayerManagerMixin.java
Outdated
Show resolved
Hide resolved
...ntity-events-v1/src/main/java/net/fabricmc/fabric/mixin/entity/event/PlayerManagerMixin.java
Outdated
Show resolved
Hide resolved
kevinthegreat1
approved these changes
Mar 26, 2023
modmuss50
reviewed
Apr 27, 2023
Comment on lines
+47
to
+55
| @ModifyVariable(method = "onPlayerConnect", ordinal = 1, at = @At(value = "INVOKE", target = "net/minecraft/server/network/ServerPlayerEntity.setWorld(Lnet/minecraft/server/world/ServerWorld;)V", shift = At.Shift.AFTER)) | ||
| private ServerWorld fixServerWorld(ServerWorld world, ClientConnection connection, ServerPlayerEntity player) { | ||
| return player.getWorld(); | ||
| } | ||
|
|
||
| @ModifyVariable(method = "onPlayerConnect", ordinal = 0, at = @At(value = "INVOKE", target = "net/minecraft/server/network/ServerPlayerEntity.setWorld(Lnet/minecraft/server/world/ServerWorld;)V", shift = At.Shift.AFTER)) | ||
| private RegistryKey<World> fixRegistryKey(RegistryKey<World> world, ClientConnection connection, ServerPlayerEntity player) { | ||
| return player.getWorld().getRegistryKey(); | ||
| } |
There was a problem hiding this comment.
Why is this needed? Some comments might be useful.
| * <p>Note: this event is not called when a player is respawned. | ||
| * For that purpose, {@link ServerPlayerEvents#COPY_FROM} should be used. | ||
| */ | ||
| public static final Event<BeforeSpawn> BEFORE_SPAWN = EventFactory.createArrayBacked(BeforeSpawn.class, callbacks -> (player) -> { |
There was a problem hiding this comment.
BEFORE_JOIN_SERVER maybe a better name? Also dont want to confuse it with ServerPlayConnectionEvents.JOIN
If anyone has any suggestions please let me know.
There was a problem hiding this comment.
BEFORE_FIRST_SPAWN is also an option because I think it's about the first spawn in a World?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new event invoked before a player is spawned (i.e. when opening a single-player world or joining a server).
Some use cases are:
I have tested it on
1.19.4and1.19.3, but it should work with most previous versions.