Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAW: Check that generated access widener matches expected output #2699

Draft
wants to merge 1 commit into
base: 1.19.3
Choose a base branch
from

Conversation

Juuxel
Copy link
Member

@Juuxel Juuxel commented Nov 26, 2022

See #2695 (comment).

This prevents builds with outdated access wideners when the MC version changes, or when template.accesswidener is modified.

Also simplifies the code a bit - text.lines().collect(Collectors.toCollection { [] }) for getting a mutable list of the lines in a file was replaced with Groovy's readLines extension method wrapped in a new ArrayList for safety.

This prevents builds with outdated access wideners when the MC version
changes, or when template.accesswidener is modified.
@Juuxel Juuxel added enhancement New feature or request small change labels Nov 26, 2022
@modmuss50
Copy link
Member

This is a good start, however there are a few modules that have generated TAWs and/or resources. This only covers one module. Running the generateResources task during the github action run and then ensuing that git has no changed files may be an easier way to do this?

@Juuxel
Copy link
Member Author

Juuxel commented Nov 29, 2022

That's true but needs some more work with the scripting (ofc individually doing my thing for all modules would take more time still) and this can be used locally for validation which is a plus.

I might still PR the clean-ups from here though, no reason to use streams here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants