Allow Message to Player Event

[BlueZeeKing]

Message API ALLOW_MESSAGE_TO_PLAYER

Resolves

Implements some of #1147

What is this?

This adds the ALLOW_MESSAGE_TO_PLAYER event to ServerMessageEvents. It's similar to the ALLOW_COMMAND_MESSAGE and ALLOW_CHAT_MESSAGE but it operates on a per-player basis. It applies to any messages a player sends, including commands like /msg, /say, and /me and messages sent as normal chat messages through the GUI.

What does this not do?

This API does not apply to messages sent by anything other than a player.

Testing

This mod uses the same mixins that the former Message Channels used so all that testing is still useful. I further tested it using the current API with the /msg, /say, and /me commands. It was also tested on sending messages from things other than a player using /execute. The testmod blocks the player from seeing any message with their username in it.

[haykam821]

The documentation makes a few grammatical mistakes and does not follow the convention of prefixing @param and @return descriptions with lowercase letters.

[apple502j]

I believe message channels are a bit out of scope. Mods can implement it easily now that AllowChatMessage event exists.

That said, if we do provide it, then we should use that event instead of mixin. Also how would message channel work with commands, particularly ones /executed?

[apple502j]

Ah, this is per-player. Then we need a new event, yeah. That said we should provide this as generic event, not usage-specific one.

[BlueZeeKing]

Ah, this is per-player. Then we need a new event, yeah. That said we should provide this as generic event, not usage-specific one.

I think you're right. I can keep the mixins the same and add the event.

[apple502j]

Note to self: this does send header packet, so that's good