add fix to AFTER_PLAYER_CHANGE_WORLD #2456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m end to overworld
|
Not sure if this is the best idea, two different things should not trigger the same event. |
|
I mean, as long as the event is only called once when a player changed worlds, I would say that this is fine. I would not expect the average person using the api to expect that AFTER_PLAYER_CHANGE_WORLD does not apply to changing worlds from the end to the overworld. |
|
If the player is killed and resurrected, wouldn't some sort of player resurrect event make more sense for this? |
|
They aren't really killed. They are just removed from all worlds while they are on the credits screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workaround to still call the AFTER_PLAYER_CHANGE_WORLD event when a player is moving from the end to the overworld.