-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Methods in TheEndBiomeData
that query the intended type.
#2369
Open
quiqueck
wants to merge
13
commits into
FabricMC:1.19
Choose a base branch
from
quiqueck:add_end_biome_type_query
base: 1.19
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b6ca651
Add methods to `TheEndBiomeData`that allow mods to query the intended…
quiqueck d39e1bc
Using correct Map
quiqueck c868e22
JavaDoc for public API class
quiqueck bbea66e
Search for actual values not only keys
quiqueck 34d9f06
Renamed Methods
quiqueck ec8c545
Check for correct biome types
quiqueck 5f489cd
Included Patch and removed unneeded code
quiqueck 6264937
Renamed
quiqueck f9488ee
Update fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/api/biom…
quiqueck 1e63441
Update fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/api/biom…
quiqueck bc1c412
Update fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/api/biom…
quiqueck 229d970
Update fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/api/biom…
quiqueck 23b8f45
Update fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/api/biom…
quiqueck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, you might want to look into changing
TheEndBiomeData#ADDED_BIOMES
into aMap<RegistryKey<Biome>, RegistryKey<Biome>>
instead, with vanilla biome as its value. Then you can check if the value is equal to the vanilla biome.Patch file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is much cleaner. I'll include the suggested patch...